[libc-commits] [PATCH] D157535: [libc] Fix printf %f bugs

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/test/src/stdio/sprintf_test.cpp:1303
+      "000000000000000000000000000000000000000000000000000000000000000000000001"
+      "131959884853339045938639911360973972585316399767392273697826861241937664"
+      "824105639342441431495119762431744054912109728706985341609159156917030486"
----------------
Nit: Add a comment explaining why there are digits beyond the `3339` even though the literal above does not.


================
Comment at: libc/test/src/stdio/sprintf_test.cpp:1283
 
+  // Found via fuzzing
+
----------------
michaelrj wrote:
> sivachandra wrote:
> > Remove.
> same as previous, this is a category.
You can choose to leave the note about fuzzing, but the category I think is "Rounding behavior tests".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157535/new/

https://reviews.llvm.org/D157535