[libc-commits] [PATCH] D157544: [libc][Fix] Move generic stdio implementations to a new directory

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/src/stdio/CMakeLists.txt:24
 endif()
+add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/generic)
 
----------------
michaelrj wrote:
> shouldn't this be in an `else` with the above condition?
We already have a `linux/` special-case which cause this to not be built. I believe this is the same approach we do for the math since even though we make the target, if there's no top level dependency on it we won't actually use it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157544/new/

https://reviews.llvm.org/D157544