[libc-commits] [PATCH] D157427: [libc] Rework the file handling for the GPU

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/src/stdio/CMakeLists.txt:397
-    libc.src.__support.File.file
-    libc.src.__support.File.platform_file
 )
----------------
jhuber6 wrote:
> sivachandra wrote:
> > These should be listed - the actual global vars come from the deps.
> So we'll need an `if(LIBC_TARGET_ARCHITECTURE_IS_GPU)` version since the `file` dependency isn't built.
No, I mean't for the generic flavors.

```
add_entrypoint_object(
  generic_stdin
  ...
  DEPENDS
    libc.src.__support.File.file
    libc.src.__support.File.platform_file
)

...

add_stdio_entyrpoint_object(stdin)
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157427/new/

https://reviews.llvm.org/D157427