[libc-commits] [libc] 8b37431 - [libc] Fix vfprintf test colliding with fprintf

Michael Jones via libc-commits libc-commits at lists.llvm.org
Wed Aug 9 10:32:02 PDT 2023


Author: Michael Jones
Date: 2023-08-09T10:31:58-07:00
New Revision: 8b37431024589a76796c0198fd532149aab7506b

URL: https://github.com/llvm/llvm-project/commit/8b37431024589a76796c0198fd532149aab7506b
DIFF: https://github.com/llvm/llvm-project/commit/8b37431024589a76796c0198fd532149aab7506b.diff

LOG: [libc] Fix vfprintf test colliding with fprintf

Sometimes the vfprintf test was failing, I suspect that's due to it
using the same filename as the fprintf test. This patch fixes that
problem by changing the filename of the vfprintf output file.

Reviewed By: lntue

Differential Revision: https://reviews.llvm.org/D157523

Added: 
    

Modified: 
    libc/test/src/stdio/vfprintf_test.cpp

Removed: 
    


################################################################################
diff  --git a/libc/test/src/stdio/vfprintf_test.cpp b/libc/test/src/stdio/vfprintf_test.cpp
index d7c5eb8292e5b5..31facdb6b16212 100644
--- a/libc/test/src/stdio/vfprintf_test.cpp
+++ b/libc/test/src/stdio/vfprintf_test.cpp
@@ -47,7 +47,7 @@ int call_vfprintf(::FILE *__restrict stream, const char *__restrict format,
 }
 
 TEST(LlvmLibcVFPrintfTest, WriteToFile) {
-  const char *FILENAME = "fprintf_output.test";
+  const char *FILENAME = "vfprintf_output.test";
   auto FILE_PATH = libc_make_test_file_path(FILENAME);
 
   ::FILE *file = printf_test::fopen(FILE_PATH, "w");


        


More information about the libc-commits mailing list