[libc-commits] [PATCH] D157523: [libc] Fix vfprintf test colliding with fprintf

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Wed Aug 9 10:21:37 PDT 2023


michaelrj created this revision.
michaelrj added reviewers: sivachandra, lntue.
Herald added projects: libc-project, All.
Herald added a subscriber: libc-commits.
michaelrj requested review of this revision.

Sometimes the vfprintf test was failing, I suspect that's due to it
using the same filename as the fprintf test. This patch fixes that
problem by changing the filename of the vfprintf output file.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157523

Files:
  libc/test/src/stdio/vfprintf_test.cpp


Index: libc/test/src/stdio/vfprintf_test.cpp
===================================================================
--- libc/test/src/stdio/vfprintf_test.cpp
+++ libc/test/src/stdio/vfprintf_test.cpp
@@ -47,7 +47,7 @@
 }
 
 TEST(LlvmLibcVFPrintfTest, WriteToFile) {
-  const char *FILENAME = "fprintf_output.test";
+  const char *FILENAME = "vfprintf_output.test";
   auto FILE_PATH = libc_make_test_file_path(FILENAME);
 
   ::FILE *file = printf_test::fopen(FILE_PATH, "w");


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157523.548668.patch
Type: text/x-patch
Size: 474 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230809/fbeb4e99/attachment.bin>


More information about the libc-commits mailing list