[libc-commits] [PATCH] D157404: [libc] Support poky system

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Aug 8 12:05:24 PDT 2023


michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.

LGTM with nit



================
Comment at: libc/cmake/modules/LLVMLibCArchitectures.cmake:167
+elseif(LIBC_TARGET_OS STREQUAL "poky")
+  set(LIBC_TARGET_OS_IS_LINUX TRUE)
+  set(LIBC_TARGET_OS "linux")
----------------
Nit: there should be a comment explaining what `poky` is and why it's equivalent to `linux` here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157404/new/

https://reviews.llvm.org/D157404



More information about the libc-commits mailing list