[libc-commits] [PATCH] D157405: [libc] add the CPP algorithm header for min/max

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Aug 8 08:58:20 PDT 2023


jhuber6 added a comment.

These should probably be `constexpr` and need `LIBC_INLINE`. If you want to go the extra mile you'd use type traits to confirm that `T::operator<` exists, but I don't think that's necessary. Make the first use of this the usage in `rpc_utils.h`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157405/new/

https://reviews.llvm.org/D157405



More information about the libc-commits mailing list