[libc-commits] [PATCH] D150211: [libc] Rework of cpp::optional to support more types

Mikhail Ramalho via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Aug 3 07:01:07 PDT 2023


mikhail.ramalho added a comment.

In D150211#4554897 <https://reviews.llvm.org/D150211#4554897>, @michaelrj wrote:

> I will think about it, but as a general note we don't really want to add a whole bunch of features we aren't using. That sort of untested and unused code has a tendency to break with newer changes.

Thanks for considering it, Michael, but I get your point, I'll try to remove the unused pieces from this PR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150211/new/

https://reviews.llvm.org/D150211



More information about the libc-commits mailing list