[libc-commits] [PATCH] D156981: [libc] Better IntegerToString API

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Aug 3 06:54:05 PDT 2023


jhuber6 added inline comments.


================
Comment at: libc/src/__support/integer_to_string.h:94
+
+using BinString = details::Config<2>;
+using OctString = details::Config<8>;
----------------
I'm not a fan of the name, since this isn't a string it's a config for the radix. Could we do something like `radix::Decimal`, etc?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156981/new/

https://reviews.llvm.org/D156981



More information about the libc-commits mailing list