[libc-commits] [PATCH] D153395: Populating 'libmgpu.a' for math on the GPU

Anton Rydahl via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Aug 1 12:36:02 PDT 2023


AntonRydahl added a comment.

In D153395#4551428 <https://reviews.llvm.org/D153395#4551428>, @arsenm wrote:

> In D153395#4551304 <https://reviews.llvm.org/D153395#4551304>, @AntonRydahl wrote:
>
>> In D153395#4551023 <https://reviews.llvm.org/D153395#4551023>, @arsenm wrote:
>>
>>> In D153395#4550720 <https://reviews.llvm.org/D153395#4550720>, @jhuber6 wrote:
>>>
>>>> We can probably just go with the generic version even if it may be a little slow, more likely to pass the tests. Probably just worth noting we could implement it more optimally later.
>>>
>>> I’d just go for the overload for now
>>
>> I am sorry, but I don't understand what you mean by overloading in this context. Could you please phrase it in another way?
>
> Leave what you have calling the ocml nextafter

Thanks for the clarification!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153395/new/

https://reviews.llvm.org/D153395



More information about the libc-commits mailing list