[libc-commits] [PATCH] D149398: [libc] Add support for global ctors / dtors for AMDGPU

[Jon Chesterfield via Phabricator via libc-commits]

JonChesterfield requested changes to this revision.
JonChesterfield added a comment.
This revision now requires changes to proceed.

Counting on the global looks like a DIY barrier, which is ok, but I can't see anything that stops reordering of operations past the initialisation code run on thread zero.



================
Comment at: libc/startup/gpu/amdgpu/start.cpp:71
+  gpu::sync_threads();
+}
 
----------------
This is missing a fence. Noth


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149398/new/

https://reviews.llvm.org/D149398