[libc-commits] [PATCH] D149487: [libc][NFC] Start cleanup of time functions

[Roland McGrath via Phabricator via libc-commits]

mcgrathr added inline comments.


================
Comment at: libc/include/llvm-libc-types/time_t.h:12
 
-typedef __INTPTR_TYPE__ time_t;
+typedef __INT64_TYPE__ time_t;
 
----------------
sivachandra wrote:
> `__INTPTR_TYPE__` might not be the most appropriate, but I am not sure `__INT64_TYPE__` is appropriate also? I suggest that you separate this part out to a different patch so that the actual clean up can land while we discuss about the definition of `time_t`.
Agreed on separating semantic from cosmetic changes.
About the time_t defn, this has traditionally been considered part of the OS ABI.
It probably still needs to be, since things like `struct stat` and whatnot that you generally want to be OS-provided use the type and you want to match the OS semantics for minimum and maximum values expected to get there.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149487/new/

https://reviews.llvm.org/D149487