[libc-commits] [PATCH] D149493: [libc] Fix printing on the GPU when given a `cpp::string_ref`

Joseph Huber via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Apr 28 16:28:58 PDT 2023


jhuber6 added inline comments.


================
Comment at: libc/utils/gpu/loader/Server.h:37
+      str_size = size;
+      str = malloc(size);
+      return str;
----------------
sivachandra wrote:
> Why not `new` and `delete`?
Good point, just more used to using `malloc` and `free`. I'll change it before landing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149493/new/

https://reviews.llvm.org/D149493



More information about the libc-commits mailing list