[libc-commits] [PATCH] D149487: [libc][NFC] Start cleanup of time functions

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added a comment.

OK after excluding one change from this patch.



================
Comment at: libc/include/llvm-libc-types/time_t.h:12
 
-typedef __INTPTR_TYPE__ time_t;
+typedef __INT64_TYPE__ time_t;
 
----------------
`__INTPTR_TYPE__` might not be the most appropriate, but I am not sure `__INT64_TYPE__` is appropriate also? I suggest that you separate this part out to a different patch so that the actual clean up can land while we discuss about the definition of `time_t`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149487/new/

https://reviews.llvm.org/D149487