[libc-commits] [PATCH] D148943: [libc] Enable multiple threads to use RPC on the GPU

Jon Chesterfield via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Apr 28 06:34:10 PDT 2023


JonChesterfield added a comment.

What's the reasoning behind the placement of sync_lanecalls? If it's meant to be one per basic block some are missing. The comment says it's added to close but the code has more calls than that.

If it's an amdgpu specific hack it should probably be named based on that and excluded on nvptx. Currently it reads like nvptx picks up a lot of synchronisation it doesn't need.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148943/new/

https://reviews.llvm.org/D148943



More information about the libc-commits mailing list