[libc-commits] [PATCH] D149306: [libc] Support the string conversion methods on the GPU

[Michael Jones via Phabricator via libc-commits]

michaelrj added a comment.

LGTM with a nit.



================
Comment at: libc/src/__support/FPUtil/PlatformDefs.h:20
 // https://developer.apple.com/documentation/xcode/writing-arm64-code-for-apple-platforms
-#if defined(_WIN32) || defined(__arm__) ||                                     \
-    (defined(__APPLE__) && defined(__aarch64__))
+#if defined(_WIN32) || defined(__arm__) || defined(__NVPTX__) ||               \
+    defined(__AMDGPU__) || (defined(__APPLE__) && defined(__aarch64__))
----------------
Nit: given the precedent of putting a comment with a link to the relevant documentation above, it would be nice to have a link to the AMD or Nvidia documentation saying they use long double as double.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149306/new/

https://reviews.llvm.org/D149306