[libc-commits] [PATCH] D149216: [libc] Add path to include generated headers for hermetic tests

[Siva Chandra via Phabricator via libc-commits]

sivachandra accepted this revision.
sivachandra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libc/test/UnitTest/CMakeLists.txt:51
 
+if(LLVM_LIBC_FULL_BUILD)
+  target_include_directories(LibcTestMain PRIVATE ${LIBC_BUILD_DIR}/include)
----------------
Nit: Move lines 56 and 57 above this `if` condition.


================
Comment at: libc/test/UnitTest/CMakeLists.txt:54
+  target_compile_options(LibcTestMain PRIVATE ${LIBC_HERMETIC_TEST_COMPILE_OPTIONS}
+                         -fno-exceptions -fno-rtti)
+endif()
----------------
Remove these as they will be added outside of the `if` anyway.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149216/new/

https://reviews.llvm.org/D149216