[libc-commits] [PATCH] D148797: [libc] Start to refactor riscv platform abstraction to support both 32 and 64 bits versions
Siva Chandra via Phabricator via libc-commits
libc-commits at lists.llvm.org
Wed Apr 26 09:38:55 PDT 2023
sivachandra added a comment.
This change LGTM in general. But, I would like to have instructions on how to test this before I accept it. Couple of reasons:
1. We want to have an estimate for the public CI.
2. Since this patch is unifying riscv64 and riscv32, I want to see how much of riscv32 actually works. Things like, if a riscv64 change does not work for riscv32, would we require that the contributor/patch author block on riscv32 changes?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148797/new/
https://reviews.llvm.org/D148797
More information about the libc-commits
mailing list