[libc-commits] [PATCH] D149216: [libc] Add path to include generated headers for hermetic tests

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/test/UnitTest/CMakeLists.txt:29
   target_include_directories(${lib} PUBLIC ${LIBC_SOURCE_DIR})
+  if(LIBC_ENABLE_HERMETIC_TESTS AND NOT LIBC_ENABLE_UNITTESTS)
+    target_include_directories(${lib} PRIVATE ${LIBC_BUILD_DIR}/include)
----------------
Can we do:

```
if(LLVM_LIBC_FULL_BUILD)
  # If we are in full build mode, then we should use our own public headers.
  target_include_directories(${lib} PRIVATE ${LIBC_BUILD_DIR}/include)
endif()
```

We don't need the one on line 43?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149216/new/

https://reviews.llvm.org/D149216