[libc-commits] [PATCH] D148784: [libc] Run all unit tests, irrespective of whether they belong to a test suite.

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Apr 24 10:33:25 PDT 2023


michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: libc/test/src/math/CMakeLists.txt:1575
+
+if(NOT LLVM_LIBC_FULL_BUILD)
+  add_subdirectory(exhaustive)
----------------
sivachandra wrote:
> michaelrj wrote:
> > is there a better way to do this so that these tests can still be built under fullbuild, even if they aren't part of the default set?
> The exhaustive tests (use MPFR) and differential tests (compare against the system libc) are built against the system libc/system libraries. So, we cannot build them cleanly in the full build mode wherein we assume no system libraries are available.
That makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148784/new/

https://reviews.llvm.org/D148784



More information about the libc-commits mailing list