[libc-commits] [PATCH] D148756: [libc] Add rule named `add_libc_hermetic_test` which adds a hermetic test.

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

In D148756#4292265 <https://reviews.llvm.org/D148756#4292265>, @jhuber6 wrote:

> I should probably enable a "malloc" that just allocates from a fixed size pool like we do in the integration tests, better than nothing.

This patch adds a `HermeticTestUtils.cpp` which does that.

>>> 2. The calls to `::free` and `::realloc` in `src/__support/CPP/string.h` did not compile when I tried, they were undefined in the module.
>>
>> Did not compile or did they produce linker errors? The allocator functions come from the hermetic test framework, just like with the integration test framework.
>
> Didn't compile, it was a C++ thing.

May be this: https://reviews.llvm.org/D149075

> Alright, I'll need to make a version that eschews the mutexes most likely.

We need pass-through mutexes for other contexts also. So, we should have a more generic no-mutex solution.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148756/new/

https://reviews.llvm.org/D148756