[libc-commits] [PATCH] D148786: [libc] Actually run integration tests.

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Thu Apr 20 11:51:42 PDT 2023


michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.

LGTM with nit



================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:537
+  # to expand the list (by including the option COMMAND_EXPAND_LISTS). This
+  # makes `add_custom_target` to construct the correct command and execute it.
+  set(test_cmd
----------------
nit: remove "to"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148786/new/

https://reviews.llvm.org/D148786



More information about the libc-commits mailing list