[libc-commits] [PATCH] D148756: [libc] Add rule named `add_libc_hermetic_test` which adds a hermetic test.

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:623
+    # The NVIDIA 'nvlink' linker does not currently support static libraries.
+    $<$<BOOL:${LIBC_TARGET_ARCHITECTURE_IS_GPU}>:${link_object_files}>
+    ${HERMETIC_TEST_SRCS}
----------------
This is a typo I just fixed upstream.


================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:673
+    COMMAND ${HERMETIC_TEST_ENV}
+            $<$<BOOL:${LIBC_TARGET_ARCHITECTURE_IS_GPU}>:${gpu_loader_exe}>
+            $<TARGET_FILE:${fq_build_target_name}> ${HERMETIC_TEST_ARGS}
----------------
Small change here just today that adds `LOADER_ARGS` to support calling tests with multiple threads on the GPU.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148756/new/

https://reviews.llvm.org/D148756