[libc-commits] [libc] eece195 - [libc] Fix not using the static library on amdgpu

Joseph Huber via libc-commits libc-commits at lists.llvm.org
Wed Apr 19 18:06:44 PDT 2023


Author: Joseph Huber
Date: 2023-04-19T20:05:30-05:00
New Revision: eece19515570bc0eb85247904421ae5f09e33c4e

URL: https://github.com/llvm/llvm-project/commit/eece19515570bc0eb85247904421ae5f09e33c4e
DIFF: https://github.com/llvm/llvm-project/commit/eece19515570bc0eb85247904421ae5f09e33c4e.diff

LOG: [libc] Fix not using the static library on amdgpu

Summary:
We have a CMake condition to not include this static library on NVPTX
because their linker doesn't support it. There was a typo that made this
trigger on all builds not just the NVPTX ones.

Added: 
    

Modified: 
    libc/cmake/modules/LLVMLibCTestRules.cmake

Removed: 
    


################################################################################
diff  --git a/libc/cmake/modules/LLVMLibCTestRules.cmake b/libc/cmake/modules/LLVMLibCTestRules.cmake
index 0ce5c80d7734..2322a158ada4 100644
--- a/libc/cmake/modules/LLVMLibCTestRules.cmake
+++ b/libc/cmake/modules/LLVMLibCTestRules.cmake
@@ -485,7 +485,7 @@ function(add_integration_test test_name)
     ${fq_build_target_name}
     EXCLUDE_FROM_ALL
     # The NVIDIA 'nvlink' linker does not currently support static libraries.
-    $<$<BOOL:${LIBC_TARGET_ARCHITECTURE_IS_GPU}>:${link_object_files}>
+    $<$<BOOL:${LIBC_GPU_TARGET_ARCHITECTURE_IS_NVPTX}>:${link_object_files}>
     ${INTEGRATION_TEST_SRCS}
     ${INTEGRATION_TEST_HDRS}
   )


        


More information about the libc-commits mailing list