[libc-commits] [PATCH] D148069: [LIBC] Implement remainder of posix 'sched.h' minus `SCHED_SPORADIC`

[Noah Goldstein via Phabricator via libc-commits]

goldstein.w.n added inline comments.


================
Comment at: libc/spec/posix.td:640
       [], // Macros
-      [PidT, SizeTType, CpuSetT], // Types
+      [PidT, TimeTType, StructTimeSpec, StructSchedParam], // Types
       [], // Enumerations
----------------
michaelrj wrote:
> this should still have `CpuSetT` in the Types list since it's used by `sched_getcpucount`
sched_getcpucount is gnu extension though. We have `CpuSetT` in gnu.td.


================
Comment at: libc/spec/posix.td:646
             RetValSpec<IntType>,
             []
         >,
----------------
michaelrj wrote:
> not relevant for this patch, but in a future patch it would be good to add the argument `ArgSpect<VoidType>` here. In C a function with no arguments is interpreted as having unspecified parameters, whereas a function with an argument of `void` has no arguments.
+1, is there an issue we add it now (not supported), or just leave it as todo?

As an side, what are these files for? I've had bugs in them but libc compiled fine /tests ran.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148069/new/

https://reviews.llvm.org/D148069