[libc-commits] [PATCH] D148635: [libc] Add a support library for GPU utilities

[Joseph Huber via Phabricator via libc-commits]

jhuber6 added inline comments.


================
Comment at: libc/src/__support/GPU/CMakeLists.txt:10
+
+add_header_library(
+  utils
----------------
sivachandra wrote:
> Not a strong opinion but you can simplify few things here if you use files like `nvptx_utils.h` etc. instead of nested files `nvptx/utils.h` etc.
I wanted to keep a single `utils.h` file that you can include and get the correct definition for that target.


================
Comment at: libc/src/__support/RPC/rpc.h:23
 #include "src/__support/CPP/atomic.h"
+#include "src/__support/GPU/utils.h"
 
----------------
sivachandra wrote:
> Is this new inclusion being used anywhere or is it only to make `rpc.h` expose `utils.h` implicitly? For proper layering, we normally avoid such implicit dependencies and inclusions.
A future patch will require it, so I just put it here to make sure that it worked, I can remove it for this patch if needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148635/new/

https://reviews.llvm.org/D148635