[libc-commits] [PATCH] D148069: [LIBC] Implement remainder of posix 'sched.h' minus `SCHED_SPORADIC`

[Michael Jones via Phabricator via libc-commits]

michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.

LGTM, tests pass on my end. I've left a few nits but feel free to land once they're fixed



================
Comment at: libc/spec/posix.td:640
       [], // Macros
-      [PidT, SizeTType, CpuSetT], // Types
+      [PidT, TimeTType, StructTimeSpec, StructSchedParam], // Types
       [], // Enumerations
----------------
this should still have `CpuSetT` in the Types list since it's used by `sched_getcpucount`


================
Comment at: libc/spec/posix.td:646
             RetValSpec<IntType>,
             []
         >,
----------------
not relevant for this patch, but in a future patch it would be good to add the argument `ArgSpect<VoidType>` here. In C a function with no arguments is interpreted as having unspecified parameters, whereas a function with an argument of `void` has no arguments.


================
Comment at: libc/test/src/sched/param_and_scheduler_test.cpp:37
+
+TEST(LlvmLibcSchedParamAndSchedulerTest, SchedOtherSmokeTest) {
+  libc_errno = 0;
----------------
nit: These test enough functionality that they probably shouldn't be called smoke tests. I'd recommend just calling this `SchedOtherTest` and same for the rest below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148069/new/

https://reviews.llvm.org/D148069