[libc-commits] [PATCH] D148288: [libc] Update RPC interface for system utilities on the GPU

[Jon Chesterfield via Phabricator via libc-commits]

JonChesterfield added inline comments.


================
Comment at: libc/src/__support/RPC/rpc.h:251
+
+  // Once we acquire the index we need to check if we are in a valid sending
+  // state.
----------------
jhuber6 wrote:
> JonChesterfield wrote:
> > This leaks ports if they're closed after a non-even number of send or recv calls
> The port can be opened in the Ack / Data state `0, 0` or `1, 1`. it doesn't get stuck at `1, 1` because we treat `1, 1` the same as `0, 0` in the logic.
Uh, maybe. I'm still having trouble mapping between in/data in/ack out/data out/ack bits and client!=server and the two bit, client==server models.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148288/new/

https://reviews.llvm.org/D148288