[libc-commits] [PATCH] D148600: Rebase D148288 and associated test commits by jhuber6 on D148191

Jon Chesterfield via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Apr 17 19:30:28 PDT 2023


JonChesterfield added inline comments.


================
Comment at: libc/src/__support/RPC/rpc.h:379
+  // Maintaining the invariant that a port is owned by the other side
+  // before and after Port::send or Port::recv
+  if (out == 0) {
----------------
codegen around this branch is probably a mess, written like this for clarity of exposition not for performance. In particular clang probably inlines the functor twice and will need hand holding to avoid that. Or raise outbox to a compile time parameter as I prefer and it'll fold correctly


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148600/new/

https://reviews.llvm.org/D148600



More information about the libc-commits mailing list