[libc-commits] [PATCH] D148288: [libc] Update RPC interface for system utilities on the GPU

[Jon Chesterfield via Phabricator via libc-commits]

JonChesterfield added a comment.

@tue



================
Comment at: libc/src/__support/RPC/rpc.h:251
+
+  // Once we acquire the index we need to check if we are in a valid sending
+  // state.
----------------
This leaks ports if they're closed after a non-even number of send or recv calls


================
Comment at: libc/utils/gpu/loader/Server.h:47
+    port->recv([](__llvm_libc::rpc::Buffer *) { /* no-op */ });
+    return;
+  }
----------------
This leaks the port here^


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148288/new/

https://reviews.llvm.org/D148288