[libc-commits] [PATCH] D147961: [libc] Update supported riscv libs

Mon Apr 17 11:45:21 PDT 2023

mikhail.ramalho added a comment.

In D147961#4274137 <https://reviews.llvm.org/D147961#4274137>, @sivachandra wrote:

> The last time I checked, `log10` had failures. Was it fixed with the FMA change?

Do you mean these messages?

  [1735/2157] Running unit test libc.test.src.math.log10_test
  [ RUN      ] LlvmLibcLog10Test.SpecialNumbers
  [       OK ] LlvmLibcLog10Test.SpecialNumbers
  [ RUN      ] LlvmLibcLog10Test.TrickyInputs
  [       OK ] LlvmLibcLog10Test.TrickyInputs
  [ RUN      ] LlvmLibcLog10Test.InDoubleRange
   Test Rounding To Nearest...
   Log10 failed: 0/1234562/1234562 tests.
     Max ULPs is at most: 0.5.
   Test Rounding Downward...
   Log10 failed: 0/1234562/1234562 tests.
     Max ULPs is at most: 0.5.
   Test Rounding Upward...
   Log10 failed: 0/1234562/1234562 tests.
     Max ULPs is at most: 0.5.
   Test Rounding Toward Zero...
   Log10 failed: 0/1234562/1234562 tests.
     Max ULPs is at most: 0.5.
  [       OK ] LlvmLibcLog10Test.InDoubleRange
  Ran 3 tests.  PASS: 3  FAIL: 0

Both x86_64 and riscv64 print them, and the test doesn't fail.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147961/new/

https://reviews.llvm.org/D147961