[libc-commits] [PATCH] D148485: [libc] Add the '--threads' and '--blocks' option to the GPU loaders

[Johannes Doerfert via Phabricator via libc-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, one nit.



================
Comment at: libc/utils/gpu/loader/Main.cpp:40
+    else if (argv[offset] == std::string("--blocks"))
+      params.num_blocks_x = atoi(argv[offset + 1]);
+  }
----------------
move this first, then emit an error if the file was not opened.
Right now random args will be ignored.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148485/new/

https://reviews.llvm.org/D148485