[libc-commits] [PATCH] D147738: [libc] Enable linux directory entries syscalls in riscv64

[Jessica Clarke via Phabricator via libc-commits]

jrtc27 added inline comments.


================
Comment at: libc/include/llvm-libc-types/ino64_t.h:12
+
+typedef __UINTPTR_TYPE__ ino64_t;
+
----------------
mikhail.ramalho wrote:
> jrtc27 wrote:
> > uintptr_t is most certainly not the same thing as ino64_t. I remember complaining about ino_t and time_t(?) being typedef'ed to that a while back but nobody fixed it. NAK on this though; use proper types.
> I just double-checked and in glibc it's defined as `__uint64_t` in 32 bits and `unsigned long int` in 64 bits.
> 
> We can use `__UINT64_TYPE__` then (`long long unsigned int` in 32 bits and `long unsigned int` in 64 bits).
FYI Darwin (unnecessarily? for consistency?) uses unsigned long long even on 64-bit for uint64_t but that's fine, it does still define ino_t as uint64_t.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147738/new/

https://reviews.llvm.org/D147738