[libc-commits] [PATCH] D147738: [libc] Enable linux directory entries syscalls in riscv64

Jessica Clarke via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Apr 17 07:01:04 PDT 2023


jrtc27 requested changes to this revision.
jrtc27 added inline comments.
This revision now requires changes to proceed.


================
Comment at: libc/include/llvm-libc-types/ino64_t.h:12
+
+typedef __UINTPTR_TYPE__ ino64_t;
+
----------------
uintptr_t is most certainly not the same thing as ino64_t. I remember complaining about ino_t and time_t(?) being typedef'ed to that a while back but nobody fixed it. NAK on this though; use proper types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147738/new/

https://reviews.llvm.org/D147738



More information about the libc-commits mailing list