[libc-commits] [PATCH] D148295: [LIBC} Put todo on making cpp::array::end() method constexpr

[Noah Goldstein via Phabricator via libc-commits]

goldstein.w.n created this revision.
Herald added projects: libc-project, All.
Herald added a subscriber: libc-commits.
goldstein.w.n requested review of this revision.

michaelrj, sivachandra


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D148295

Files:
  libc/src/__support/CPP/array.h


Index: libc/src/__support/CPP/array.h
===================================================================
--- libc/src/__support/CPP/array.h
+++ libc/src/__support/CPP/array.h
@@ -43,6 +43,9 @@
   constexpr const_iterator begin() const { return Data; }
 
   constexpr iterator end() { return Data + N; }
+
+  // TODO: Marking this constexpr causes a variety of test/build failures. Look
+  // into that and fix.
   const_iterator end() const { return Data + N; }
 };
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D148295.513422.patch
Type: text/x-patch
Size: 469 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20230414/9626d22c/attachment.bin>