[libc-commits] [PATCH] D148069: [LIBC] Implement remainder of posix 'sched.h' minus `SCHED_SPORADIC`

[Siva Chandra via Phabricator via libc-commits]

sivachandra added a comment.

Few more nits but I will let @michaelrj drive this review.



================
Comment at: libc/include/llvm-libc-macros/linux/sched-macros.h:13
+// Copy values from linux/sched.h:
+// https://elixir.bootlin.com/linux/latest/source/include/uapi/linux/sched.h
+#define SCHED_BATCH 3
----------------
Instead of `Copy ...`, say something like, `The definitions here match those in linux/sched.h`.


================
Comment at: libc/include/llvm-libc-macros/sched-macros.h:13
+// These defines are req by posix, These values are from linux/sched.h:
+// https://elixir.bootlin.com/linux/latest/source/include/uapi/linux/sched.h
+#define SCHED_OTHER 0
----------------
Ditto.


================
Comment at: libc/include/llvm-libc-macros/sched-macros.h:16
+#define SCHED_FIFO 1
+#define SCHED_RR 2
+// Not yet implemented SCHED_SPORADIC
----------------
I missed this last time: These definitions are also based on `linux/sched.h` so they should stay in `linux/sched-macros.h`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148069/new/

https://reviews.llvm.org/D148069