[libc-commits] [PATCH] D148069: [LIBC] Implement remainder of posix 'sched.h' minus `SCHED_SPORADIC`

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/include/llvm-libc-macros/linux/sched-macros.h:15
+#define SCHED_IDLE 5
+#define SCHED_DEADLINE 6
+
----------------
Can you add a comment explaining how these numbers were picked? If they were picked to be in sync with the Linux kernel, mention the kernel header which defines them.


================
Comment at: libc/include/llvm-libc-macros/sched-macros.h:14
+#define SCHED_FIFO 1
+#define SCHED_RR 2
+
----------------
Same here.


================
Comment at: libc/test/src/sched/rr_get_interval_test.cpp:1
+//===-- Unittests for sched_rr_get_internval -----------------------------===//
+//
----------------
Extra `n`.


================
Comment at: libc/test/src/sched/rr_get_interval_test.cpp:1
+//===-- Unittests for sched_rr_get_internval -----------------------------===//
+//
----------------
sivachandra wrote:
> Extra `n`.
Also, why is the file not named `sched_rr_get_interval_test.cpp`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148069/new/

https://reviews.llvm.org/D148069