[libc-commits] [PATCH] D147919: [libc] Add implementation of getchar

Siva Chandra via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Apr 11 22:18:55 PDT 2023


sivachandra accepted this revision.
sivachandra added inline comments.


================
Comment at: libc/src/stdio/getchar.cpp:24
+
+  if (r != 1)
+    return EOF;
----------------
Nit: This can be `if (result.value != 1)`. Same in `getchar_unlocked`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147919/new/

https://reviews.llvm.org/D147919



More information about the libc-commits mailing list