[libc-commits] [PATCH] D147822: [libc] Add memmem implementation

[Roland McGrath via Phabricator via libc-commits]

mcgrathr added a comment.

In D147822#4259080 <https://reviews.llvm.org/D147822#4259080>, @gchatelet wrote:

> Sorry for the lag, Monday was off in France and I missed the patch today.
> I'm not blocking this patch but please consider the suggested changes.

These are good suggestions and easy to apply right away before landing.



================
Comment at: libc/test/src/string/memmem_test.cpp:97
+    char h[] = {'\0'};
+    char n[] = {
+        '\0',
----------------
gchatelet wrote:
> same here
Note that clang-format will use separate lines for each element when there is a trailing comma before the end-brace, and will compact things when there is no trailing comma.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147822/new/

https://reviews.llvm.org/D147822