[libc-commits] [PATCH] D147919: [libc] Add implementation of getchar

[Michael Jones via Phabricator via libc-commits]

michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.

LGTM with these changes. I can commit for you.



================
Comment at: libc/spec/posix.td:1064
+              RetValSpec<IntType>,
+              [ArgSpec<>]
+          >,
----------------
xbjfk wrote:
> Is this the correct way to define a function that takes no arguments?
good catch, it should be `ArgSpec<VoidType>`


================
Comment at: libc/spec/stdc.td:586
+              RetValSpec<IntType>,
+              [ArgSpec<>]
+          >,
----------------
same here, it should be `ArgSpec<VoidType>`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147919/new/

https://reviews.llvm.org/D147919