[libc-commits] [PATCH] D147463: [libc] Move str{, r}chr implementation to headers

Guillaume Chatelet via Phabricator via libc-commits libc-commits at lists.llvm.org
Tue Apr 11 01:57:25 PDT 2023


gchatelet added a comment.

Sorry for the delayed response.
I missed the requirement that the tests should be independent. Given that the build system decides which functions are to be tested, it's difficult to use the templated approach I was suggested.

LGTM


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147463/new/

https://reviews.llvm.org/D147463



More information about the libc-commits mailing list