[libc-commits] [PATCH] D147813: [libc] clean up ctype negative handling

Roland Illig via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Apr 10 16:11:46 PDT 2023


rillig added a comment.

The implementation of the `<ctype.h>` functions only needs to accept EOF or a value representable as `unsigned char`. Testing the functions with other negative numbers may invoke undefined behavior, as the implementation need not handle these numbers. Therefore, the words "such as" from the commit message sound misleading to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147813/new/

https://reviews.llvm.org/D147813



More information about the libc-commits mailing list