[libc-commits] [PATCH] D147970: [libc] Add swab implementation

Caslyn Tonelli via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Apr 10 13:59:06 PDT 2023


Caslyn marked 2 inline comments as done.
Caslyn added inline comments.


================
Comment at: libc/src/unistd/linux/swab.cpp:17
+                   (const void *__restrict from, void *__restrict to,
+                    size_t n)) {
+  const unsigned char *f = static_cast<const unsigned char *>(from);
----------------
michaelrj wrote:
> this should be `ssize_t`
Thanks for catching - included size check as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147970/new/

https://reviews.llvm.org/D147970



More information about the libc-commits mailing list