[libc-commits] [PATCH] D147970: [libc] Add swab implementation

[Michael Jones via Phabricator via libc-commits]

michaelrj added inline comments.


================
Comment at: libc/spec/posix.td:550
+          RetValSpec<VoidType>,
+          [ArgSpec<ConstVoidRestrictedPtr>, ArgSpec<VoidPtr>, ArgSpec<SizeTType>]
+        >,
----------------
this should be `SSizeTType`


================
Comment at: libc/src/unistd/linux/swab.cpp:17
+                   (const void *__restrict from, void *__restrict to,
+                    size_t n)) {
+  const unsigned char *f = static_cast<const unsigned char *>(from);
----------------
this should be `ssize_t`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147970/new/

https://reviews.llvm.org/D147970