[libc-commits] [PATCH] D147822: [libc] Add memmem implementation

Michael Jones via Phabricator via libc-commits libc-commits at lists.llvm.org
Mon Apr 10 10:51:23 PDT 2023


michaelrj added a comment.

Code looks good to me, I've added @gchatelet for his opinion on `memmem` being in `memory_utils`.



================
Comment at: libc/src/string/memmem.cpp:1
-//===-- Implementation of strstr ------------------------------------------===//
+//===-- Implementation of memmem _-----------------------------------------===//
 //
----------------
nit: typo


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147822/new/

https://reviews.llvm.org/D147822



More information about the libc-commits mailing list