[libc-commits] [PATCH] D147919: [libc] Add implementation of getchar

[Michael Jones via Phabricator via libc-commits]

michaelrj added a comment.

In our codebase we try to avoid calling entrypoints from other entrypoints. In this case that means not calling `getc` from `getchar`, instead mostly copying the code. This may seem silly, but it allows users to include any entrypoint on its own without having to worry about dependencies.

Other than that, this patch looks good, I'll approve it once that change is made.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147919/new/

https://reviews.llvm.org/D147919