[libc-commits] [PATCH] D147755: [libc][math] Update range reduction step for logf and reduce its latency.

Tue Ly via Phabricator via libc-commits libc-commits at lists.llvm.org
Fri Apr 7 04:22:27 PDT 2023


lntue added a comment.

In D147755#4250692 <https://reviews.llvm.org/D147755#4250692>, @zimmermann6 wrote:

> the patch fails to apply to main (revision 10cff75 <https://reviews.llvm.org/rG10cff75f12b270d856a4ff36e76a1b8441d6e2ff>):
>
>   $ patch -p1 -i /tmp/D147755.diff 
>   patching file libc/src/math/generic/common_constants.h
>   Hunk #1 succeeded at 17 with fuzz 2 (offset -3 lines).
>   patching file libc/src/math/generic/common_constants.cpp
>   Hunk #1 FAILED at 109.
>   Hunk #2 succeeded at 102 with fuzz 2 (offset -28 lines).
>   1 out of 2 hunks FAILED -- saving rejects to file libc/src/math/generic/common_constants.cpp.rej
>   patching file libc/src/math/generic/logf.cpp
>   patching file libc/test/src/math/logf_test.cpp

Can you try to apply https://reviews.llvm.org/D147676 before this patch to see if it works?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147755/new/

https://reviews.llvm.org/D147755



More information about the libc-commits mailing list