[libc-commits] [PATCH] D147503: [libc] Implement strsep

[Alex Brachet via Phabricator via libc-commits]

abrachet added inline comments.


================
Comment at: libc/src/string/string_utils.h:197
 
-  for (; *src != '\0' && delimiter_set.test(*src); ++src)
-    ;
+  if (SkipDelim)
+    for (; *src != '\0' && delimiter_set.test(*src); ++src)
----------------
michaelrj wrote:
> Nit: This should be `if constexpr (SkipDelim)` to make it clear this is a compile-time if statement.
Done in commit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147503/new/

https://reviews.llvm.org/D147503