[libc-commits] [PATCH] D147478: [libc] Add strxfrm Implementation
Michael Jones via Phabricator via libc-commits
libc-commits at lists.llvm.org
Wed Apr 5 10:08:51 PDT 2023
michaelrj accepted this revision.
michaelrj added a comment.
This revision is now accepted and ready to land.
LGTM after fixing one issue.
================
Comment at: libc/src/string/strxfrm.cpp:18
+// TODO: Add support for locales.
+LLVM_LIBC_FUNCTION(size_t, strxfrm, (char *dest, const char *src, size_t n)) {
+ size_t len = internal::string_length(src);
----------------
The pointer arguments for strxfrm need to be tagged with `__restrict` both here and in the header.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147478/new/
https://reviews.llvm.org/D147478
More information about the libc-commits
mailing list