[libc-commits] [PATCH] D147375: [libc] Use string_view for write_to_stderr

Sat Apr 1 05:18:42 PDT 2023

gchatelet added a comment.

In D147375#4238339 <https://reviews.llvm.org/D147375#4238339>, @jhuber6 wrote:

> Do we want to stop using `const char *`? We only use this internally currently, but it was easier for me to test when it was a C type. I'll let @sivachandra decide.

`cpp::string_view` is implicitly constructible from a `const char*` so the current code still works. Are you calling the function from C code?
Relevant discussion for this patch: https://reviews.llvm.org/D147231#inline-1423241

================
Comment at: libc/src/__support/OSUtil/gpu/io.cpp:22
+
+LIBCI_INLINE void send_null_terminated(cpp::string_view src) {
+  rpc::client.run(
----------------
jhuber6 wrote:
> 
Thx for catching the typo!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147375/new/

https://reviews.llvm.org/D147375